Skip to content

Update sample code for documentation VB.NET "what's new : language features : Tuples" - #3166

Merged
BillWagner merged 2 commits into
dotnet:masterfrom
Styxxy:master
Sep 18, 2017
Merged

BillWagner merged 2 commits into
dotnet:masterfrom
Styxxy:master

Conversation

@Styxxy

@Styxxy Styxxy commented Sep 18, 2017

Copy link
Copy Markdown
Contributor

Title

In the code snippers of the documentation for VB.NET about Tuples, I found a small error.

Snippet 3 outputs the original string that is being parsed, rather than the output. It should output the result, as it is also being outputted in snippet 1 (the "original" version, before using the new language features). Another minor thing : the variable name of the "to be parsed string" maybe should match the original version?

Summary

  • Changed the culture info used
  • Fixed sample snippet 3

Fixes #3165

@dnfclas

dnfclas commented Sep 18, 2017

Copy link
Copy Markdown

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

@svick svick left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but someone from Microsoft will have to also review the Pull Request for it to be accepted.

@BillWagner BillWagner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this @Styxxy We appreciate it. The changes are more clear for readers to understand how tuples are used.

I'll :shipit: once the build finishes. These changes should will show up on the live site on our next publish cycle, within a day or so.

@BillWagner
BillWagner merged commit 0a4dfe6 into dotnet:master Sep 18, 2017
rpetrusha pushed a commit that referenced this pull request Sep 20, 2017
* fix constructor remarks formatting. (#3141)

* fix constructor remarks formatting.

* another instance

* Update String.xml

* Update String.xml

* | didn't render to `|` properly (#3162)

* Added missing space between two words (#3161)

* M10669: Possible typo mistake: 'SC1721' (#3167)

@wiwagn,
It seems that 'SC1721' is a typo of 'CS1721'. Could you help to review this and reply, please?
Many thanks in advance!

* Update sample code for documentation VB.NET "what's new : language features : Tuples" (#3166)

* what's new Tuples : sample use InvariantCulture

* vb tuple example fix new language feature sample

* fixed broken link (#3169)

* fixed pipes in tables (#3163)

* added info about relative paths for output (#3042)

* added info about relative paths for output

* edits

* Update how-to-write-a-simple-parallel-for-loop.md (#3174)

Updated Cut to Copy in Copy/Cut and Paste this code into ...

* fixed formulas (#3182)

* fixed formulas

* fixed formula

* fixed formula

* simplifying version list (#3176)

* Minor fixes : inconsistent wording and some ghost characters (#3171)

* what's new Tuples : sample use InvariantCulture

* vb tuple example fix new language feature sample

* minor typos

* compiler warning corrected to match previously mentioned number
* removed a "ghost" quote

* fixed inconsistent "read-only" and "read only"

* code formatting (missing space)

* Adding C# version history post (#2867)

* Create csharp-version-history.md

* Added the actual text

* Updated TOC with my entry.

* first pass edit

1. Add Metadata
1. Change person
1. Formalize from blog post to docs style language.

* Update csharp-version-history.md

* fix build warnings on links.

* respond to feedback

* fixed build warnings

* fixed version capitalization
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants